Hacktoberfest - Issue #2, Pull Requesrt #2

It is 1:30 am and it is already October 11, time is flying. Only 20 more days left until the end of Hacktoberfest. The fight is keep going. It is not a regular fight it is a fight over fears to contribute to open source, specially for "newbies" like me. My issue #1 and pull request #1 are different from what I have done this time. This time I took advice from my professor I decide to contribute to well known project Gutenberg from WordPress.

Issue #2 Overview:

Programming language: JavaScript
Problem: Fix variable names for better reading the code

Function reduce() except accumulator as a parameter @tofumatt who is a member of the project required to update variable name with suffix 'accumulator' to improve code readability. Originally there were 49 lines of code that required to fix names of a variable.  In the beginning I thought that I just will fix 1 or 2 variable names and will send a pull request, but than I realize why wouldn't give it a try and fix more variables names. My classmate decide to work on this project with same issue as well, so we split the number of variables names.

Here are screenshots of what is done so far



























Now my PR is submitted and I'm very excited that I try to contribute to a big project. When I contribute to the project like Gutenberg I feel different then when I contribute to a smaller project or issues that had been made particular for the Hacktoberfest. I don't know if my pull request will be excepted but I want to continue my tries to contribute to bigger projects.

Problem, difficulties and outcomes related to issue #2 and PR #2:

1. First of all I did same mistake as I did with my issue #1, I did not give myself enough time to search and work on issue. My professor give advice in the class that if I spend 6 hours on setting up an environment and start working on issue it will be more productive than looping through the issues that will fill my needs and level of knowledge

2. Working on a big project is more "scary" than on a small project but in the end they are more productive and benefit us in many ways

3.Before I start work on the issue I was not very familiar with the function reduce() from JavaScript,  so I had to spend about half an hour on reading the documentation what is that about. This helped me to expand my knowledge on this function in JavaScript

Issue #2 and Pull Request #2 are done and I hope that my corrections will be excepted and I will be real contributor to something big like Gutenberg Project


Comments

Post a Comment

Popular posts from this blog

Release 0.6

Image
Going back to Telescope. Between release 0.5 and 0.6 I was working on the Telescope project. I was assign to few issues during the 2 weeks period.  My first issue was to add test to make sure our application starts. This issue reference to the page where possibly I can look for solution. Ideally issue -363 should solve: a) make sure that our app is working b) allowed to hit correct root. After reading examples and documentation I have learned that there is 'start-serve-and-test' npm package that starts server, waits for URL, then runs test command; when tests end, shuts down server.  How to use this package: Install this package  npm i  start-server-and-test Add command to the script. In my case Telescope already has command to start server and command for the tests. This way I just had to combine both commands into one that I named "CI" and add localhost.  Indeed this package did not solve the intention  of the issue I was working on. This packa
Read more

Hacktoberfest - Issue#3 PR#3

Image
It's been already 3rd week of October and this is mean that Hacktoberfest is going to an end just in 11 days. More PR and more lines of coding, different projects and different problems all this is very familiar to anybody who are in Open Source and specially for the one who participate in Hacktoberfest. In Lab 3 the main task is same as in Lab 1 and Lab 2  it's to find an issue, fix it and create Pull Request. As other times this could not go smoothly. My Lab 2 was base on the contribution to the WordPress Gutenberg project . In Lab 3 I've decided to keep working on the same project but I picked different issue . What was the issue about. To use the proper terms in code to match the Designer Handbook  of Gutenberg project. In the project there are terms "inspector" and "sidebar" which have same meaning. The task was to change name "inspector" to "sidebar". Only JS itself contains 67 files that has name "inspector".
Read more

Back on Track or working on the Table Reservation Application

Image
Table Reservation Application is an application with many features. One of the most important features is to reserve a table online and send the form to the restaurant. All summer me and my other two teammates try to accomplish many milestones of this project but due to heavy loads from other subject not everything was implemented. Two months I could not sleep without writing lines of code in order to complete this project. In the end this is how many lines of code I wrote and delete.  Even it is looks like a lot of line of code in the end of the day many features were left out. It hurts me to see that such a beautiful idea was not implemented till the end. Beside that, contributing to the project help me to learn many new things and be on top of the technologies. For example I was able to learn angular material UI. This application was desighn for PRJ666 course in order to graduate from Seneca college with Computer Programming and Analysis diploma. This mean that if I decide to have d
Read more